Inheco ODTC in PLR

starting a public thread because many people are interested in/working on the odtc

@ben made the first PR for the ODTC today: add inheco odtc backend by ben-ray · Pull Request #841 · PyLabRobot/pylabrobot · GitHub

also @cody just sent he is working on a branch: GitHub - cmoscy/pylabrobot at odtc

we have both 96 and 384 well thermocyclers in the lab, so my plan is to test this locally and go ahead with merging Ben’s branch first. I aim to get this done either today or at least early this week. I will make sure it replicates on our machines and works with the Thermocycler standard in PLR, but won’t be adding new functionality. After that, I will welcome PRs to improve his implementation.

c @rkaptur @Cody @CamilloMoschner @ben

2 Likes

@ben Happy to follow your lead on this one. If it’s useful, I got most of the Sila and odtc communication into the branch I’m working on here. Currently, it runs the protocols we’ve put on board the instrument nicely, and can write custom premethod/methods (although without Inheco’s overshoot logic for now).

There’s some async handling, and error codes that the odtc supports that are not in the original communication layer from the incubators module. I’ve subclassed out the new stuff to prevent any interference/breaking changes for now.

I’ve got an overview and an example notebook that should make taking a look pretty quick.

Still neds some polish, but if there’s anything in there that’s useful, or if I can help out just let me know.

3 Likes

your implementation is very nicely documented! lots here to merge

2 Likes

Hey! Hope things went well at SLAS. Put some work in on this to get our ODTC96 working in lab, more or less have a complete control layer that maps to the existing Thermocycler resource/protocol too for commands like set mount temp, etc. Added it as a PR if you guys wanted to take a look.

3 Likes