ThermoFisher ND1000 Support

Hi PLR team!

I’m Jord and I recently built a backend implementation for the ThermoFisher ND1000 as part of an open-science project for my university (Wageningen / WUR). This is my first time posting so I’m a little shy and don’t know what to do so I’m just winging it haha! I worked with vcjdeboer on this a bit, but due to my student status I was also a bit busy on my internship and thesis during this project :confused: I’m still quite new to Github and only more of a hobby programmer despite having a good few hours in python now, but that means most of this might be a bit rough around the edges, apologies.

I just discovered the contributor guidelines today (sorry for not getting in touch before writing the code!), but since the code was already working well locally, I’ve gone ahead and submitted a PR to the v1b1 branch here: Add ND1000 open science project backend support by Jordvl · Pull Request #1166 · PyLabRobot/pylabrobot · GitHub (this is a requirement for the project as well :slight_smile: )

The PR includes:

  • setup instructions for windows, as its an old dinky device and needs a bit of a workaround…

  • a python script which hopefully falls within the v1b1 guidelines and works as my original one does…

  • I’ve only tested it on windows for now, but Ill be happy to do small updates whenever I have time to work on it again!

I would love any feedback on the file structure or if any architectural changes are needed to better fit the v1b1 standards!

3 Likes

apologies for the late response

this is sick! I’ll respond in more detail on GitHub in a bit